Remove keypad code, and were_pressed. #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dhalbert
approved these changes
Jul 23, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 24, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.0.0 from 4.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#108 from kattni/remove-were-pressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion, it was decided to remove
were_pressedaltogether which eliminates the need forgamepad(deprecated) orkeypad. This is an API BREAKING CHANGE, and will require a full version bump.were_pressedis not used in any internal projects that I can find, so no example code is affected.